[CLEANUP] Avoid multiline strings in OutputFormatTest - #1429
Merged
Conversation
Also avoid literal tabs.
oliverklee
force-pushed
the
cleanup/multiline-in-outputformattest
branch
from
December 14, 2025 20:17
779193d to
69887d7
Compare
oliverklee
changed the title
OutputFormatTestOutputFormatTest
JakeQZ
approved these changes
Dec 14, 2025
| self::assertSame( | ||
| '.main, .test {font: italic normal bold 16px/1.2 "Helvetica",Verdana,sans-serif;background: white;} | ||
| @media screen {.main {background-size: 100% 100%;font-size: 1.3em;background-color: #fff;}}', | ||
| ".main, .test {font: italic normal bold 16px/1.2 \"Helvetica\",Verdana,sans-serif;background: white;}\n" |
Collaborator
There was a problem hiding this comment.
It's debatable whether such a string should be single-quoted, with "\n" concatenated. Either way is fine I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also avoid literal tabs.